From 226f4dfdfb5c65c7cb966f47cbc6a550a805c051 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 16 May 2013 17:02:27 -0700 Subject: [PATCH 1/2] rustc: One less bad copy --- src/librustc/middle/trans/base.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/librustc/middle/trans/base.rs b/src/librustc/middle/trans/base.rs index e14d6d79ab5..b5cca20d8ec 100644 --- a/src/librustc/middle/trans/base.rs +++ b/src/librustc/middle/trans/base.rs @@ -2228,8 +2228,7 @@ pub fn register_fn_fuller(ccx: @CrateContext, mangle_exported_name(ccx, /*bad*/copy path, node_type) }; - // XXX: Bad copy. - let llfn: ValueRef = decl_fn(ccx.llmod, copy ps, cc, llfty); + let llfn: ValueRef = decl_fn(ccx.llmod, ps, cc, llfty); ccx.item_symbols.insert(node_id, ps); // FIXME #4404 android JNI hacks From 1bf4f902913b0d02f5a2a7a0c6675ff76e9cffe5 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 16 May 2013 17:25:19 -0700 Subject: [PATCH 2/2] rustc: Remove import that is, indeed, not necessary --- src/librustc/middle/trans/datum.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/librustc/middle/trans/datum.rs b/src/librustc/middle/trans/datum.rs index 374bb23f2cb..8055d919ffd 100644 --- a/src/librustc/middle/trans/datum.rs +++ b/src/librustc/middle/trans/datum.rs @@ -101,7 +101,6 @@ use middle::ty; use util::common::indenter; use util::ppaux::ty_to_str; -use core::container::Set; // XXX: this should not be necessary use core::to_bytes; use syntax::ast; use syntax::codemap::span;