mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix the comment

Browse source 
It's worse than I thought...
This commit is contained in:
Daniel McNab 2021-03-07 13:13:54 +00:00
parent 419b5a1bee
commit 877f745551
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/project_model/src/workspace.rs
View file

@ -478,16 +478,16 @@ fn handle_rustc_crates(
// The root package of the rustc-dev component is rustc_driver, so we match that // The root package of the rustc-dev component is rustc_driver, so we match that
let root_pkg = let root_pkg =
rustc_workspace.packages().find(|package| rustc_workspace[*package].name == "rustc_driver"); rustc_workspace.packages().find(|package| rustc_workspace[*package].name == "rustc_driver");
// The rustc workspace might be incomplete (such as if rustc-dev is not installed for the current toolchain) // The rustc workspace might be incomplete (such as if rustc-dev is not
// and `rustcSource` is set to discover. // installed for the current toolchain) and `rustcSource` is set to discover.
if let Some(root_pkg) = root_pkg { if let Some(root_pkg) = root_pkg {
// Iterate through every crate in the dependency subtree of rustc_driver using BFS // Iterate through every crate in the dependency subtree of rustc_driver using BFS
let mut queue = VecDeque::new(); let mut queue = VecDeque::new();
queue.push_back(root_pkg); queue.push_back(root_pkg);
while let Some(pkg) = queue.pop_front() { while let Some(pkg) = queue.pop_front() {
// Don't duplicate packages if they are dependended on a diamond pattern // Don't duplicate packages if they are dependended on a diamond pattern
// N.B. if this line is ommitted, we try and analyse either 48_000 or 480_000 crates // N.B. if this line is ommitted, we try to analyse over 4_800_000 crates
// neither of which makes // which is not ideal
if rustc_pkg_crates.contains_key(&pkg) { if rustc_pkg_crates.contains_key(&pkg) {
continue; continue;
} }