mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix a case where a RustBook command is potentially not executed

Browse source 
We can move the command creation to a block where it is clear that the command will be executed.
This commit is contained in:
Jakub Beránek 2024-07-07 13:28:14 +02:00 • committed by Jakub Beránek
parent 9634633889
commit 8ee18d600f
No known key found for this signature in database
GPG key ID: 909CD0D26483516B
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/bootstrap/src/core/build_steps/doc.rs
View file

@ -146,7 +146,6 @@ impl<P: Step> Step for RustbookSrc<P> {
let out = out.join(&name);
let index = out.join("index.html");
let rustbook = builder.tool_exe(Tool::Rustbook);
let mut rustbook_cmd = builder.tool_cmd(Tool::Rustbook);
if !builder.config.dry_run()
&& (!up_to_date(&src, &index) || !up_to_date(&rustbook, &index))
@ -154,7 +153,13 @@ impl<P: Step> Step for RustbookSrc<P> {
builder.info(&format!("Rustbook ({target}) - {name}"));
let _ = fs::remove_dir_all(&out);
rustbook_cmd.arg("build").arg(&src).arg("-d").arg(&out).run(builder);
builder
.tool_cmd(Tool::Rustbook)
.arg("build")
.arg(&src)
.arg("-d")
.arg(&out)
.run(builder);
for lang in &self.languages {
let out = out.join(lang);