mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

show unaccounted for time in profiling

Browse source
This commit is contained in:
Aleksey Kladov 2019-10-24 09:05:11 +03:00
parent 2197205885
commit baa968e71c
1 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
crates/ra_prof/src/lib.rs
View file

@ -198,7 +198,7 @@ impl Drop for Profiler {
let stdout = stderr(); let stdout = stderr();
let longer_than = stack.filter_data.longer_than; let longer_than = stack.filter_data.longer_than;
if duration >= longer_than { if duration >= longer_than {
print(0, &stack.messages, &mut stdout.lock(), longer_than); print(0, &stack.messages, &mut stdout.lock(), longer_than, None);
} }
stack.messages.clear(); stack.messages.clear();
} }
@ -209,20 +209,28 @@ impl Drop for Profiler {
} }
} }
fn print(lvl: usize, msgs: &[Message], out: &mut impl Write, longer_than: Duration) { fn print(
lvl: usize,
msgs: &[Message],
out: &mut impl Write,
longer_than: Duration,
total: Option<Duration>,
) {
let mut last = 0; let mut last = 0;
let indent = repeat(" ").take(lvl + 1).collect::<String>(); let indent = repeat(" ").take(lvl + 1).collect::<String>();
// We output hierarchy for long calls, but sum up all short calls // We output hierarchy for long calls, but sum up all short calls
let mut short = Vec::new(); let mut short = Vec::new();
let mut accounted_for = Duration::default();
for (i, &Message { level, duration, message: ref msg }) in msgs.iter().enumerate() { for (i, &Message { level, duration, message: ref msg }) in msgs.iter().enumerate() {
if level != lvl { if level != lvl {
continue; continue;
} }
accounted_for += duration;
if duration >= longer_than { if duration >= longer_than {
writeln!(out, "{} {:6}ms - {}", indent, duration.as_millis(), msg) writeln!(out, "{} {:6}ms - {}", indent, duration.as_millis(), msg)
.expect("printing profiling info to stdout"); .expect("printing profiling info to stdout");
print(lvl + 1, &msgs[last..i], out, longer_than); print(lvl + 1, &msgs[last..i], out, longer_than, Some(duration));
} else { } else {
short.push((msg, duration)) short.push((msg, duration))
} }
@ -240,6 +248,15 @@ fn print(lvl: usize, msgs: &[Message], out: &mut impl Write, longer_than: Durati
writeln!(out, "{} {:6}ms - {} ({} calls)", indent, total_duration.as_millis(), msg, count) writeln!(out, "{} {:6}ms - {} ({} calls)", indent, total_duration.as_millis(), msg, count)
.expect("printing profiling info to stdout"); .expect("printing profiling info to stdout");
} }
if let Some(total) = total {
if let Some(unaccounted) = total.checked_sub(accounted_for) {
if unaccounted >= longer_than && last > 0 {
writeln!(out, "{} {:6}ms - ???", indent, unaccounted.as_millis())
.expect("printing profiling info to stdout");
}
}
}
} }
/// Prints backtrace to stderr, useful for debugging. /// Prints backtrace to stderr, useful for debugging.