mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Explicitly skipping suggestions for 'Pin' as it does not implement the 'AsRef' trait

Browse source
This commit is contained in:
Yuval Dolev 2021-10-29 15:43:33 +03:00
parent e2151497bf
commit cad2d21cb6
2 changed files with 6 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
compiler/rustc_typeck/src/check/method/suggest.rs
View file

@ -15,7 +15,7 @@ use rustc_middle::ty::print::with_crate_prefix;
use rustc_middle::ty::{self, ToPredicate, Ty, TyCtxt, TypeFoldable, WithConstness};
use rustc_span::lev_distance;
use rustc_span::symbol::{kw, sym, Ident};
use rustc_span::{source_map, FileName, MultiSpan, Span};
use rustc_span::{source_map, FileName, MultiSpan, Span, Symbol};
use rustc_trait_selection::traits::query::evaluate_obligation::InferCtxtExt;
use rustc_trait_selection::traits::{FulfillmentError, Obligation};
@ -1301,7 +1301,11 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
// We don't want to suggest a container type when the missing
// method is `.clone()` or `.deref()` otherwise we'd suggest
// `Arc::new(foo).clone()`, which is far from what the user wants.
let skip = skippable.contains(&did);
// Explicitly ignore the `Pin::as_ref()` method as `Pin` does not
// implement the `AsRef` trait.
let skip = skippable.contains(&did)
|| (("Pin::new" == *pre)
&& (Symbol::intern("as_ref") == item_name.name));
// Make sure the method is defined for the *actual* receiver: we don't
// want to treat `Box<Self>` as a receiver if it only works because of
// an autoderef to `&self`

17
src/test/ui/typeck/issue-89806.stderr
View file

@ -3,23 +3,6 @@ error[E0599]: no method named `as_ref` found for type `u8` in the current scope
|
LL | 0u8.as_ref();
| ^^^^^^ method not found in `u8`
|
::: $SRC_DIR/core/src/pin.rs:LL:COL
|
LL | pub fn as_ref(&self) -> Pin<&P::Target> {
| ------
| |
| the method is available for `Pin<&mut u8>` here
| the method is available for `Pin<&u8>` here
|
help: consider wrapping the receiver expression with the appropriate type
|
LL | Pin::new(&mut 0u8).as_ref();
| +++++++++++++ +
help: consider wrapping the receiver expression with the appropriate type
|
LL | Pin::new(&0u8).as_ref();
| ++++++++++ +
error: aborting due to previous error