mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rollup merge of #128402 - oli-obk:checked_attrs, r=compiler-errors

Browse source 
Attribute checking simplifications

remove an unused boolean and then merge two big matches into one

I was reviewing some attributes and realized we don't really check this list against the list of builtin attributes, so we "may" totally be missing some attributes that we should be checking (like the `coroutine` attribute, which you can just apply to random stuff)

```rust
#![feature(coroutines)]
#[coroutine]
struct Foo;
```

just compiles for example. Unless we check that the fallthrough match arm is never reached for builtin attributes, we're just going to keep forgetting to add them here, too. I can do that without the changes in this PR, but it seemed like a nice cleanup
This commit is contained in:
Matthias Krüger 2024-07-31 15:36:32 +02:00 • committed by GitHub
commit e2d8f1ac21
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 179 additions and 367 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

546
compiler/rustc_passes/src/check_attr.rs
View file

File diff suppressed because it is too large Load diff