mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rollup merge of #127711 - BoxyUwU:add_effects_test, r=fee1-dead

Browse source 
Add regression test for a gce + effects ICE

Fixes #125770

I'm not *exactly* sure why this stopped ICEing, I assume its something to do with the fact that there used to be a generic parameter on `Add` for the host generic and we have mismatched args here, which #125608 made no longer later cause issues. But now the desugaring is also different so? 🤷‍♀️

r? `@fee1-dead`
This commit is contained in:
Matthias Krüger 2024-07-14 20:25:00 +02:00 • committed by GitHub
commit f19cb0b294
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 88 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/ui/rfcs/rfc-2632-const-trait-impl/effects/mismatched_generic_args.rs Normal file
View file

@ -0,0 +1,24 @@
#![feature(generic_const_exprs)]
//~^ WARN: the feature `generic_const_exprs` is incomplete
// Regression test for #125770 which would ICE under the old effects desugaring that
// created a const generic parameter for constness on `Add`.
use std::ops::Add;
pub struct Dimension;
pub struct Quantity<S, const D: Dimension>(S);
//~^ ERROR: `Dimension` is forbidden as the type of a const generic parameter
impl<const D: Dimension, LHS, RHS> Add<LHS, D> for Quantity<LHS, { Dimension }> {}
//~^ ERROR: trait takes at most 1 generic argument
//~| ERROR: `Dimension` is forbidden as the type of a const generic parameter
pub fn add<const U: Dimension>(x: Quantity<f32, U>) -> Quantity<f32, U> {
//~^ ERROR: `Dimension` is forbidden as the type of a const generic parameter
x + y
//~^ ERROR: cannot find value `y` in this scope
}
fn main() {}

64
tests/ui/rfcs/rfc-2632-const-trait-impl/effects/mismatched_generic_args.stderr Normal file
View file

@ -0,0 +1,64 @@
error[E0425]: cannot find value `y` in this scope
--> $DIR/mismatched_generic_args.rs:20:9
|
LL | pub fn add<const U: Dimension>(x: Quantity<f32, U>) -> Quantity<f32, U> {
| - similarly named const parameter `U` defined here
LL |
LL | x + y
| ^ help: a const parameter with a similar name exists: `U`
warning: the feature `generic_const_exprs` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/mismatched_generic_args.rs:1:12
|
LL | #![feature(generic_const_exprs)]
| ^^^^^^^^^^^^^^^^^^^
|
= note: see issue #76560 <https://github.com/rust-lang/rust/issues/76560> for more information
= note: `#[warn(incomplete_features)]` on by default
error: `Dimension` is forbidden as the type of a const generic parameter
--> $DIR/mismatched_generic_args.rs:11:33
|
LL | pub struct Quantity<S, const D: Dimension>(S);
| ^^^^^^^^^
|
= note: the only supported types are integers, `bool` and `char`
help: add `#![feature(adt_const_params)]` to the crate attributes to enable more complex and user defined types
|
LL + #![feature(adt_const_params)]
|
error[E0107]: trait takes at most 1 generic argument but 2 generic arguments were supplied
--> $DIR/mismatched_generic_args.rs:14:36
|
LL | impl<const D: Dimension, LHS, RHS> Add<LHS, D> for Quantity<LHS, { Dimension }> {}
| ^^^ expected at most 1 generic argument
error: `Dimension` is forbidden as the type of a const generic parameter
--> $DIR/mismatched_generic_args.rs:14:15
|
LL | impl<const D: Dimension, LHS, RHS> Add<LHS, D> for Quantity<LHS, { Dimension }> {}
| ^^^^^^^^^
|
= note: the only supported types are integers, `bool` and `char`
help: add `#![feature(adt_const_params)]` to the crate attributes to enable more complex and user defined types
|
LL + #![feature(adt_const_params)]
|
error: `Dimension` is forbidden as the type of a const generic parameter
--> $DIR/mismatched_generic_args.rs:18:21
|
LL | pub fn add<const U: Dimension>(x: Quantity<f32, U>) -> Quantity<f32, U> {
| ^^^^^^^^^
|
= note: the only supported types are integers, `bool` and `char`
help: add `#![feature(adt_const_params)]` to the crate attributes to enable more complex and user defined types
|
LL + #![feature(adt_const_params)]
|
error: aborting due to 5 previous errors; 1 warning emitted
Some errors have detailed explanations: E0107, E0425.
For more information about an error, try `rustc --explain E0107`.