mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Review feedback for collect_intra_doc_links.rs

Browse source 
* Add assertion value is defined.
* Simplify comment.
* Fix bad change in err message.
This commit is contained in:
Eric Arellano 2020-12-07 15:07:24 -07:00
parent d2de69da2e
commit f68cc68e79
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/librustdoc/passes/collect_intra_doc_links.rs
View file

@ -435,8 +435,9 @@ impl<'a, 'tcx> LinkCollector<'a, 'tcx> {
// Try looking for methods and associated items.
let mut split = path_str.rsplitn(2, "::");
// NB: the `splitn`'s first element is always defined, even if the delimiter is not present.
// NB: `split`'s first element is always defined, even if the delimiter was not present.
let item_str = split.next().unwrap();
assert!(!item_str.is_empty());
let item_name = Symbol::intern(item_str);
let path_root = split
.next()
@ -448,7 +449,7 @@ impl<'a, 'tcx> LinkCollector<'a, 'tcx> {
ResolutionFailure::NotResolved {
module_id,
partial_res: None,
unresolved: path_str.into(),
unresolved: item_str.into(),
}
})?;