From bc8093ed551546730194a2b726dbd39466d199d0 Mon Sep 17 00:00:00 2001 From: hyd-dev Date: Sat, 13 Mar 2021 18:50:43 +0800 Subject: [PATCH 1/2] Fix panic message of `assert_failed_inner` --- library/core/src/panicking.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/core/src/panicking.rs b/library/core/src/panicking.rs index 12acf5b4329..3e3e96fcd7f 100644 --- a/library/core/src/panicking.rs +++ b/library/core/src/panicking.rs @@ -154,7 +154,7 @@ fn assert_failed_inner( Some(args) => panic!( r#"assertion failed: `(left {} right)` left: `{:?}`, - right: `{:?}: {}`"#, + right: `{:?}`: {}"#, op, left, right, args ), None => panic!( From 7ecb5d86014f4da127c3d17c4b9fea3b344e7cde Mon Sep 17 00:00:00 2001 From: hyd-dev Date: Sat, 13 Mar 2021 19:14:57 +0800 Subject: [PATCH 2/2] Add regression tests --- src/test/ui/macros/assert-eq-macro-msg.rs | 9 +++++++++ src/test/ui/macros/assert-matches-macro-msg.rs | 11 +++++++++++ src/test/ui/macros/assert-ne-macro-msg.rs | 9 +++++++++ 3 files changed, 29 insertions(+) create mode 100644 src/test/ui/macros/assert-eq-macro-msg.rs create mode 100644 src/test/ui/macros/assert-matches-macro-msg.rs create mode 100644 src/test/ui/macros/assert-ne-macro-msg.rs diff --git a/src/test/ui/macros/assert-eq-macro-msg.rs b/src/test/ui/macros/assert-eq-macro-msg.rs new file mode 100644 index 00000000000..accbd2d1e7f --- /dev/null +++ b/src/test/ui/macros/assert-eq-macro-msg.rs @@ -0,0 +1,9 @@ +// run-fail +// error-pattern:panicked at 'assertion failed: `(left == right)` +// error-pattern: left: `2` +// error-pattern:right: `3`: 1 + 1 definitely should be 3' +// ignore-emscripten no processes + +fn main() { + assert_eq!(1 + 1, 3, "1 + 1 definitely should be 3"); +} diff --git a/src/test/ui/macros/assert-matches-macro-msg.rs b/src/test/ui/macros/assert-matches-macro-msg.rs new file mode 100644 index 00000000000..43be9532f5d --- /dev/null +++ b/src/test/ui/macros/assert-matches-macro-msg.rs @@ -0,0 +1,11 @@ +// run-fail +// error-pattern:panicked at 'assertion failed: `(left matches right)` +// error-pattern: left: `2` +// error-pattern:right: `3`: 1 + 1 definitely should be 3' +// ignore-emscripten no processes + +#![feature(assert_matches)] + +fn main() { + assert_matches!(1 + 1, 3, "1 + 1 definitely should be 3"); +} diff --git a/src/test/ui/macros/assert-ne-macro-msg.rs b/src/test/ui/macros/assert-ne-macro-msg.rs new file mode 100644 index 00000000000..fc0472b99b4 --- /dev/null +++ b/src/test/ui/macros/assert-ne-macro-msg.rs @@ -0,0 +1,9 @@ +// run-fail +// error-pattern:panicked at 'assertion failed: `(left != right)` +// error-pattern: left: `2` +// error-pattern:right: `2`: 1 + 1 definitely should not be 2' +// ignore-emscripten no processes + +fn main() { + assert_ne!(1 + 1, 2, "1 + 1 definitely should not be 2"); +}