mathieu/os-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
os-rust/src/test/ui/non-fmt-panic.stderr

281 lines
9.6 KiB
Text
Raw Normal View History

Small cleanups in assert!() and panic_fmt lint. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-19 21:14:05 +02:00
warning: panic message contains a brace
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:11:29
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
LL | panic!("here's a brace: {");
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
| ^
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Add s to non_fmt_panic
2021-06-29 20:33:31 +02:00
= note: `#[warn(non_fmt_panics)]` on by default
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string, but will be in Rust 2021
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
help: add a "{}" format string to use the message literally
|
LL | panic!("{}", "here's a brace: {");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
Small cleanups in assert!() and panic_fmt lint. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-19 21:14:05 +02:00
warning: panic message contains a brace
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:12:31
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
LL | std::panic!("another one: }");
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
| ^
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string, but will be in Rust 2021
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
help: add a "{}" format string to use the message literally
|
LL | std::panic!("{}", "another one: }");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
Small cleanups in assert!() and panic_fmt lint. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-19 21:14:05 +02:00
warning: panic message contains an unused formatting placeholder
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:13:25
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
LL | core::panic!("Hello {}");
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
| ^^
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string when given without arguments, but will be in Rust 2021
Improve panic_fmt lint messages. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-29 19:44:06 +01:00
help: add the missing argument
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
|
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
LL | core::panic!("Hello {}", ...);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
help: or add a "{}" format string to use the message literally
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
LL | core::panic!("{}", "Hello {}");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
warning: panic message contains unused formatting placeholders
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:14:21
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
LL | assert!(false, "{:03x} {test} bla");
| ^^^^^^ ^^^^^^
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string when given without arguments, but will be in Rust 2021
Improve panic_fmt lint messages. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-29 19:44:06 +01:00
help: add the missing arguments
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
|
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
LL | assert!(false, "{:03x} {test} bla", ...);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Test for formating placeholders in panic_fmt lint test.
2020-10-18 23:36:00 +02:00
help: or add a "{}" format string to use the message literally
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
|
Parse the format string for the panic_fmt lint for better warnings.
2020-10-20 22:25:42 +02:00
LL | assert!(false, "{}", "{:03x} {test} bla");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:16:20
|
LL | assert!(false, S);
| ^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: add a "{}" format string to Display the message
|
LL | assert!(false, "{}", S);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
warning: panic message contains braces
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:18:27
Also apply panic_fmt lint suggestions to debug_assert!().
2020-10-19 00:45:07 +02:00
|
LL | debug_assert!(false, "{{}} bla");
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
| ^^^^
Also apply panic_fmt lint suggestions to debug_assert!().
2020-10-19 00:45:07 +02:00
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string, but will be in Rust 2021
Also apply panic_fmt lint suggestions to debug_assert!().
2020-10-19 00:45:07 +02:00
help: add a "{}" format string to use the message literally
|
LL | debug_assert!(false, "{}", "{{}} bla");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Also apply panic_fmt lint suggestions to debug_assert!().
2020-10-19 00:45:07 +02:00
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:19:12
|
LL | panic!(C);
| ^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: add a "{}" format string to Display the message
|
LL | panic!("{}", C);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(C);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:20:12
|
LL | panic!(S);
| ^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: add a "{}" format string to Display the message
|
LL | panic!("{}", S);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(S);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:21:17
|
LL | std::panic!(123);
| ^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: add a "{}" format string to Display the message
|
LL | std::panic!("{}", 123);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(123);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:22:18
|
LL | core::panic!(&*"abc");
| ^^^^^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
help: add a "{}" format string to Display the message
|
LL | core::panic!("{}", &*"abc");
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
warning: panic message contains an unused formatting placeholder
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:23:12
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
|
LL | panic!(concat!("{", "}"));
| ^^^^^^^^^^^^^^^^^
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string when given without arguments, but will be in Rust 2021
Improve panic_fmt lint messages. (From the PR feedback.) Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
2020-10-29 19:44:06 +01:00
help: add the missing argument
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
|
LL | panic!(concat!("{", "}"), ...);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
help: or add a "{}" format string to use the message literally
|
LL | panic!("{}", concat!("{", "}"));
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
warning: panic message contains braces
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:24:5
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
|
LL | panic!(concat!("{", "{"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string, but will be in Rust 2021
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
help: add a "{}" format string to use the message literally
|
LL | panic!("{}", concat!("{", "{"));
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Improve panic_fmt error messages for invalid format strings too.
2020-10-20 22:59:53 +02:00
Add test for panic_fmt lint with external panic!()-calling macro.
2020-10-29 22:21:40 +01:00
warning: panic message contains an unused formatting placeholder
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
--> $DIR/non-fmt-panic.rs:26:37
Add test for panic_fmt lint with external panic!()-calling macro.
2020-10-29 22:21:40 +01:00
|
LL | fancy_panic::fancy_panic!("test {} 123");
| ^^
|
Add lint for `panic!(123)` which is not accepted in Rust 2021. This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021. It suggests to add `"{}", ` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized `std::panic::panic_any()` function as an alternative. It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
2021-02-01 22:30:09 +01:00
= note: this message is not used as a format string when given without arguments, but will be in Rust 2021
Add test for non_fmt_panic lint for panic!(some_macro!()).
2021-02-14 18:17:34 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:36:12
|
LL | panic!(a!());
| ^^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add test for non_fmt_panic lint for panic!(some_macro!()).
2021-02-14 18:17:34 +01:00
help: add a "{}" format string to Display the message
|
LL | panic!("{}", a!());
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add test for non_fmt_panic lint for panic!(some_macro!()).
2021-02-14 18:17:34 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(a!());
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~
Add test for non_fmt_panic lint for panic!(some_macro!()).
2021-02-14 18:17:34 +01:00
Add test for panic!(format!(..)) lint.
2021-02-14 18:53:10 +01:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:38:12
|
LL | panic!(format!("{}", 1));
| ^^^^^^^^^^^^^^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add test for panic!(format!(..)) lint.
2021-02-14 18:53:10 +01:00
= note: the panic!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
LL - panic!(format!("{}", 1));
LL + panic!("{}", 1);
|
Add test for panic!(format!(..)) lint.
2021-02-14 18:53:10 +01:00
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
warning: panic message is not a string literal
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
--> $DIR/non-fmt-panic.rs:39:20
|
LL | assert!(false, format!("{}", 1));
| ^^^^^^^^^^^^^^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
= note: the assert!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
LL - assert!(false, format!("{}", 1));
LL + assert!(false, "{}", 1);
|
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:40:26
|
LL | debug_assert!(false, format!("{}", 1));
| ^^^^^^^^^^^^^^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
= note: the debug_assert!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
LL - debug_assert!(false, format!("{}", 1));
LL + debug_assert!(false, "{}", 1);
|
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
warning: panic message is not a string literal
--> $DIR/non-fmt-panic.rs:42:12
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
|
LL | panic![123];
| ^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
help: add a "{}" format string to Display the message
|
LL | panic!["{}", 123];
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(123);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~~ ~
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
warning: panic message is not a string literal
Improve "panic message is not a string literal" warning This warning always referenced panic! even in case of an assert. Related to #84656
2021-05-07 19:09:15 +02:00
--> $DIR/non-fmt-panic.rs:43:12
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
|
LL | panic!{123};
| ^^^
|
Turn non_fmt_panic into a future_incompatible edition lint.
2021-06-27 14:47:26 +00:00
= note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
help: add a "{}" format string to Display the message
|
LL | panic!{"{}", 123};
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| +++++
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
help: or use std::panic::panic_any instead
|
LL | std::panic::panic_any(123);
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 19:07:19 -07:00
| ~~~~~~~~~~~~~~~~~~~~~~ ~
Add ui tests for panic![123] and panic!{123}.
2021-02-14 19:44:57 +01:00
Silence non_fmt_panic from external macros.
2021-08-12 14:33:30 +02:00
warning: 19 warnings emitted
Add test for the panic_fmt lint.
2020-10-18 22:52:36 +02:00
Reference in a new issue Copy permalink