mathieu/os-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #13553 - SpriteOvO:manual_is_power_of_two-change-category, r=llogiq

Browse source 
Change the category of `manual_is_power_of_two` to `pedantic`

Fixes #13547.

The value being checked might be a bit flag, suggesting `is_power_of_two` for it would make the code unreadable.

changelog: [`manual_is_power_of_two`]: Change the category to `pedantic`
This commit is contained in:
bors 2024-10-15 20:02:57 +00:00 • committed by Philipp Krones
parent 4ff8ff0ecd
commit 7b688e21d6
No known key found for this signature in database
GPG key ID: 1CA0DF2AF59D68A5
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/tools/clippy/clippy_lints/src/manual_is_power_of_two.rs
View file

@ -11,10 +11,12 @@ use rustc_session::declare_lint_pass;
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for expressions like `x.count_ones() == 1` or `x & (x - 1) == 0`, with x and unsigned integer, which are manual /// Checks for expressions like `x.count_ones() == 1` or `x & (x - 1) == 0`, with x and unsigned integer, which may be manual
/// reimplementations of `x.is_power_of_two()`. /// reimplementations of `x.is_power_of_two()`.
///
/// ### Why is this bad? /// ### Why is this bad?
/// Manual reimplementations of `is_power_of_two` increase code complexity for little benefit. /// Manual reimplementations of `is_power_of_two` increase code complexity for little benefit.
///
/// ### Example /// ### Example
/// ```no_run /// ```no_run
/// let a: u32 = 4; /// let a: u32 = 4;
@ -27,7 +29,7 @@ declare_clippy_lint! {
/// ``` /// ```
#[clippy::version = "1.82.0"] #[clippy::version = "1.82.0"]
pub MANUAL_IS_POWER_OF_TWO, pub MANUAL_IS_POWER_OF_TWO,
complexity, pedantic,
"manually reimplementing `is_power_of_two`" "manually reimplementing `is_power_of_two`"
} }