mathieu/granite-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rollup merge of #132996 - clubby789:unn-let-space, r=jieyouxu

Browse source 
Trim extra space when suggesting removing bad `let`

Fixes #132969
This commit is contained in:
Matthias Krüger 2024-11-13 21:04:25 +01:00 • committed by GitHub
commit e6b3a55b98
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_parse/src/parser/pat.rs
View file

@ -683,7 +683,9 @@ impl<'a> Parser<'a> {
})
{
self.bump();
self.dcx().emit_err(RemoveLet { span: lo });
// Trim extra space after the `let`
let span = lo.with_hi(self.token.span.lo());
self.dcx().emit_err(RemoveLet { span });
lo = self.token.span;
}

8
tests/ui/parser/unnecessary-let.stderr
View file

@ -2,12 +2,12 @@ error: expected pattern, found `let`
--> $DIR/unnecessary-let.rs:2:9
|
LL | for let x of [1, 2, 3] {}
| ^^^
| ^^^^
|
help: remove the unnecessary `let` keyword
|
LL - for let x of [1, 2, 3] {}
LL + for x of [1, 2, 3] {}
LL + for x of [1, 2, 3] {}
|
error: missing `in` in `for` loop
@ -25,12 +25,12 @@ error: expected pattern, found `let`
--> $DIR/unnecessary-let.rs:7:9
|
LL | let 1 => {}
| ^^^
| ^^^^
|
help: remove the unnecessary `let` keyword
|
LL - let 1 => {}
LL + 1 => {}
LL + 1 => {}
|
error: aborting due to 3 previous errors