297b618944
take 2 open up coroutines tweak the wordings the lint works up until 2021 We were missing one case, for ADTs, which was causing `Result` to yield incorrect results. only include field spans with significant types deduplicate and eliminate field spans switch to emit spans to impl Drops Co-authored-by: Niko Matsakis <nikomat@amazon.com> collect drops instead of taking liveness diff apply some suggestions and add explantory notes small fix on the cache let the query recurse through coroutine new suggestion format with extracted variable name fine-tune the drop span and messages bugfix on runtime borrows tweak message wording filter out ecosystem types earlier apply suggestions clippy check lint level at session level further restrict applicability of the lint translate bid into nop for stable mir detect cycle in type structure
32 lines
846 B
Rust
32 lines
846 B
Rust
// This test ensures that `tail_expr_drop_order` does not activate in case Edition 2024 is used
|
|
// because this is a migration lint.
|
|
// Only `cargo fix --edition 2024` shall activate this lint.
|
|
|
|
//@ check-pass
|
|
//@ compile-flags: -Z unstable-options
|
|
//@ edition: 2024
|
|
|
|
#![deny(tail_expr_drop_order)]
|
|
|
|
struct LoudDropper;
|
|
impl Drop for LoudDropper {
|
|
fn drop(&mut self) {
|
|
// This destructor should be considered significant because it is a custom destructor
|
|
// and we will assume that the destructor can generate side effects arbitrarily so that
|
|
// a change in drop order is visible.
|
|
println!("loud drop");
|
|
}
|
|
}
|
|
impl LoudDropper {
|
|
fn get(&self) -> i32 {
|
|
0
|
|
}
|
|
}
|
|
|
|
fn should_not_lint() -> i32 {
|
|
let x = LoudDropper;
|
|
x.get() + LoudDropper.get()
|
|
// Lint should not action
|
|
}
|
|
|
|
fn main() {}
|