mathieu/os-rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
os-rust/tests/ui/inference
History
Nicholas Nethercote 72b172bdf6 Overhaul the handling of errors at the top-level. 
Currently `emit_stashed_diagnostic` is called from four(!) different
places: `print_error_count`, `DiagCtxtInner::drop`, `abort_if_errors`,
and `compile_status`.

And `flush_delayed` is called from two different places:
`DiagCtxtInner::drop` and `Queries`.

This is pretty gross! Each one should really be called from a single
place, but there's a bunch of entanglements. This commit cleans up this
mess.

Specifically, it:
- Removes all the existing calls to `emit_stashed_diagnostic`, and adds
  a single new call in `finish_diagnostics`.
- Removes the early `flush_delayed` call in `codegen_and_build_linker`,
  replacing it with a simple early return if delayed bugs are present.
- Changes `DiagCtxtInner::drop` and `DiagCtxtInner::flush_delayed` so
  they both assert that the stashed diagnostics are empty (i.e.
  processed beforehand).
- Changes `interface::run_compiler` so that any errors emitted during
  `finish_diagnostics` (i.e. late-emitted stashed diagnostics) are
  counted and cannot be overlooked. This requires adding
  `ErrorGuaranteed` return values to several functions.
- Removes the `stashed_err_count` call in `analysis`. This is possible
  now that we don't have to worry about calling `flush_delayed` early
  from `codegen_and_build_linker` when stashed diagnostics are pending.
- Changes the `span_bug` case in `handle_tuple_field_pattern_match` to a
  `delayed_span_bug`, because it now can be reached due to the removal
  of the `stashed_err_count` call in `analysis`.
- Slightly changes the expected output of three tests. If no errors are
  emitted but there are delayed bugs, the error count is no longer
  printed. This is because delayed bugs are now always printed after the
  error count is printed (or not printed, if the error count is zero).

There is a lot going on in this commit. It's hard to break into smaller
pieces because the existing code is very tangled. It took me a long time
and a lot of effort to understand how the different pieces interact, and
I think the new code is a lot simpler and easier to understand.
2024-02-22 08:03:47 +11:00
..
auxiliary Move /src/test to /tests 2023-01-11 09:32:08 +00:00
need_type_info Remove a has_errors check that only hides errors after unrelated items have errored. 2024-01-31 16:51:42 +00:00
ambiguous_type_parameter.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
ambiguous_type_parameter.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
array-len-mismatch.rs Suggest the correct array length on mismatch 2023-02-12 02:15:41 +00:00
array-len-mismatch.stderr Suggest the correct array length on mismatch 2023-02-12 02:15:41 +00:00
cannot-infer-async.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
cannot-infer-async.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
cannot-infer-closure-circular.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
cannot-infer-closure-circular.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
cannot-infer-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
cannot-infer-closure.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
cannot-infer-partial-try-return.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
cannot-infer-partial-try-return.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
char-as-str-multi.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
char-as-str-multi.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
char-as-str-single.fixed [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
char-as-str-single.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
char-as-str-single.stderr fix type suggestions in match arms 2023-03-25 22:27:24 +01:00
deref-suggestion.rs Suggest deref on comparison binop RHS even if type is not Copy 2023-04-19 16:47:11 +00:00
deref-suggestion.stderr Point at correct exprs for assert_eq type mismatch 2023-06-08 16:30:05 +00:00
erase-type-params-in-label.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
erase-type-params-in-label.stderr Deduplicate more sized errors on call exprs 2024-01-24 02:53:15 +00:00
infer-binary-operand-behind-reference.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
inference-variable-behind-raw-pointer.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
inference-variable-behind-raw-pointer.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
inference_unstable.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
inference_unstable.stderr diagnostics: update test cases to refer to assoc fn with self as method 2023-02-22 08:40:47 -07:00
inference_unstable_featured.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
inference_unstable_featured.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
inference_unstable_forced.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
inference_unstable_forced.stderr Bless tests 2024-01-13 12:46:58 -05:00
issue-12028.rs Move tests 2024-02-13 18:08:25 -03:00
issue-12028.stderr Move tests 2024-02-13 18:08:25 -03:00
issue-28935.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-36053.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-70082.rs diagnostics: add test case for already-solved issue 2023-04-25 13:07:09 -07:00
issue-70082.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-70703.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-71309.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-71309.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-71584.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-71584.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-71732.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-71732.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-72616.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-72616.stderr Tweak output of to_pretty_impl_header involving only anon lifetimes 2023-08-28 17:17:11 +00:00
issue-72690.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-72690.stderr Reorder fullfillment errors to keep more interesting ones first 2023-10-04 02:04:14 +00:00
issue-80409.no-compat.stderr Overhaul the handling of errors at the top-level. 2024-02-22 08:03:47 +11:00
issue-80409.rs Drive-by DUMMY_SP -> Span and fmt changes 2024-02-19 17:04:23 +00:00
issue-80816.rs Note predicate span on ImplDerivedObligation 2023-01-11 19:46:45 +00:00
issue-80816.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-81522.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-83606.rs defer array len printing to const arg printing 2023-01-18 04:07:39 +00:00
issue-83606.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-86094-suggest-add-return-to-coerce-ret-ty.rs Suggest adding return if the type of unused semi return value can coerce to the fn return type 2023-10-15 22:57:03 +08:00
issue-86094-suggest-add-return-to-coerce-ret-ty.stderr Suggest adding return if the type of unused semi return value can coerce to the fn return type 2023-10-15 22:57:03 +08:00
issue-86162-1.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-86162-1.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-86162-2.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-86162-2.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-103587.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-103587.stderr Support bare unit structs in destructuring assignments 2023-12-08 19:55:07 +00:00
issue-104649.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-104649.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-107090.rs Continue compilation after check_mod_type_wf errors 2024-02-14 11:00:30 +00:00
issue-107090.stderr Continue compilation after check_mod_type_wf errors 2024-02-14 11:00:30 +00:00
issue-113354.fixed [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-113354.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
issue-113354.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
lub-glb-with-unbound-infer-var.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
multiple-impl-apply.rs Reorder fullfillment errors to keep more interesting ones first 2023-10-04 02:04:14 +00:00
multiple-impl-apply.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
newlambdas-ret-infer.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
newlambdas-ret-infer2.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
question-mark-type-infer.rs Reorder fullfillment errors to keep more interesting ones first 2023-10-04 02:04:14 +00:00
question-mark-type-infer.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
range-type-infer.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
simple-infer.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
str-as-char.fixed [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
str-as-char.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00
str-as-char.stderr Fix suggestion for attempting to define a string with single quotes 2023-08-16 21:51:57 +01:00
tutorial-suffix-inference-test.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
tutorial-suffix-inference-test.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
type-infer-generalize-ty-var.rs [AUTO-GENERATED] Migrate ui tests from // to //@ directives 2024-02-16 20:02:50 +00:00